-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] added missing package field mappings #128391
[Fleet] added missing package field mappings #128391
Conversation
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🚀
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only wondering if we should also set ignore_above
for match_only_text
.
x-pack/plugins/fleet/server/services/epm/elasticsearch/template/template.ts
Show resolved
Hide resolved
@juliaElastic is there a way to test this yet with an existing package? If not, maybe we should remove the QA validation labels. |
@joshdover I saw here that Windows integration uses a multi_field, but I'm getting an error when trying to install it on latest master:
|
@juliaElastic That error should have been fixed by #128498, have you pulled latest |
@joshdover you're right, I forgot to pull locally. Now I can successfully install Windows integration. |
I believe the "Mappings" tab on that flyout only shows the mappings defined in the base index template. Since we've moved the mappings to the |
I'm checking in the Preview tab where all mappings are there. EDIT: I checked what is actually coming from the package fields, and there is no
@jsoriano do you know a package to test the new type of |
There are though some packages that have |
@joshdover I think we can remove the QA labels, as there is no package with these specific fields (multi_fields/match_only_text type or doc_values) |
Hi @juliaElastic cc: @joshdover |
@amolnater-qasource I think no testing is needed, thanks. |
Thanks @juliaElastic |
Summary
Added field mappings for:
doc_values
: false valuemulti_fields
: match_only_text typeOriginal issue: elastic/elastic-package#678
Related discussion: elastic/elastic-package#752 (comment)
Checklist